Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: 優化遊戲房間使用者體驗與新聊天室串接 web socket #407

Merged
merged 3 commits into from
Oct 5, 2024
Merged

feature: 優化遊戲房間使用者體驗與新聊天室串接 web socket #407

merged 3 commits into from
Oct 5, 2024

Conversation

JohnsonMao
Copy link
Contributor

@JohnsonMao JohnsonMao commented Oct 5, 2024 •
edited
Loading

Why need this change? / Root cause:

  • 目前不走 Happy path 會導致使用者很難回到原本的房間，故調整這部分的邏輯
  • 新的頁面聊天室調整

Changes made:

  • 遊戲房間頁面
  • 聊天室功能

Test Scope / Change impact:

  • 無

Issue

  • 無

@JohnsonMao JohnsonMao self-assigned this Oct 5, 2024
@github-actions github-actions bot added the feature New Feature label Oct 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GaaSBot
Copy link

GaaSBot commented Oct 5, 2024

✅ Knip Scan Result for ac37b36

Unused files (7)
Unused files (7)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (3)
Unused exported types (3)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 5, 2024

🤖 Lighthouse Scan Result for ac37b36

/rooms
Metric Value
Performance 69
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 60
Seo 80
Accessibility 85
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 69
Seo 80
Accessibility 95
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit bf0e9e3 into main Oct 5, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the feature/room-page branch October 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnsonMao JohnsonMao

Labels
feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnsonMao @GaaSBot